Skip to content

Validate superclass and module-self-type #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ksss merged 2 commits into from
Feb 25, 2025
Merged

Validate superclass and module-self-type #2289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bcea8e
Validate type application for superclass
ksss Feb 21, 2025
ffa7916
Validate type application for module-self-type
ksss Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/rbs/definition_builder/ancestor_builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ def one_instance_ancestors(type_name)
NoSuperclassFoundError.check!(super_name, env: env, location: primary.decl.location)
if super_class
InheritModuleError.check!(super_class, env: env)
InvalidTypeApplicationError.check2!(type_name: super_class.name, args: super_class.args, env: env, location: super_class.location)
end

super_entry = env.normalized_class_entry(super_name) or raise
Expand All @@ -243,6 +244,7 @@ def one_instance_ancestors(type_name)
else
entry.self_types.each do |module_self|
NoSelfTypeFoundError.check!(module_self, env: env)
InvalidTypeApplicationError.check2!(type_name: module_self.name, args: module_self.args, env: env, location: module_self.location)

module_name = module_self.name
if module_name.class?
Expand Down
19 changes: 19 additions & 0 deletions test/rbs/ancestor_builder_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,18 @@ class B < Y[Integer, void]
class C
extend X
end

class D
end

class E < D[Integer]
end

module F : D[Integer]
end
EOF


manager.build do |env|
builder = DefinitionBuilder::AncestorBuilder.new(env: env)

Expand All @@ -680,6 +691,14 @@ class C
assert_raises InvalidTypeApplicationError do
builder.singleton_ancestors(type_name("::C"))
end

assert_raises InvalidTypeApplicationError do
builder.instance_ancestors(type_name("::E"))
end

assert_raises InvalidTypeApplicationError do
builder.instance_ancestors(type_name("::F"))
end
end
end
end
Expand Down