Dir.mktmpdir and File.join accept Pathname #2158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File.joinusesFilePathStringValue, so it acceptsPathname.https://github.com/ruby/ruby/blob/7c2660b34774c017accff8a7d78371c2f368b9dc/file.c#L5160
Dir.mktmpdirusesFile.joininternally, so it also acceptsPathnameas parent.And it use
String.try_convertforprefix_suffix, so they acceptstringinstead ofString.https://github.com/ruby/ruby/blob/923f831804b8bc26bf0412b932791d9090ff8ac4/lib/tmpdir.rb#L159-L165