Skip loading require: false gems in collection
#1222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `rbs collection` assumes Bundler, loading *unbundled* gem fails.
soutaro
commented
Feb 1, 2023
| end | ||
| end | ||
|
|
||
| def test_generate_lock_from_collection_repository_specified |
Member
Author
There was a problem hiding this comment.
We cannot delete this test because a default gem may be required without declared in Gemfile...
Member
Author
There was a problem hiding this comment.
This should be ok. The test doesn't make any sense and to be deleted.
If a non-default gem is not included in the Bundler context, it cannot be require-ed nor Gem::Specification.find_by_name cannot find the gem.
If a default gem is implicitly loaded, it should be included in the gems section of rbs_collection.yaml or dependencies: section of manifest.yaml of a gem.
soutaro
force-pushed
the
gemfile-require
branch
from
31029bd to
fbcb2f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming gems declared in
Gemfilewithrequire: falseare apps -- not libraries, we can skip loading the RBS files of that gems in collection.LockfileGeneratorstarts from the gems declared inGemfilewithoutrequire: false, and adds them and their dependencies recursively.rbs_collection.yaml.