Skip to content

RBS::InvalidOverloadMethodError caused when the super method is defined by an extended module #1293

@pocke

Description

@pocke

Since rbs v3.0.3, rbs validate causes RBS::InvalidOverloadMethodError with the following code.

# test.rbs
module M
  def f: () -> void
end

class C1
  extend M
  def self.f: () -> void | ...
end
$ rbs _3.0.3_ -I . validate --silent
/Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/gems/3.3.0+0/gems/rbs-3.0.3/lib/rbs/definition_builder.rb:716:in `define_method': test.rbs:7:2...7:30: Invalid method overloading: ::C1#f (RBS::InvalidOverloadMethodError)
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/gems/3.3.0+0/gems/rbs-3.0.3/lib/rbs/definition_builder.rb:580:in `block in import_methods'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/gems/3.3.0+0/gems/rbs-3.0.3/lib/rbs/definition_builder/method_builder.rb:56:in `block in each'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/3.3.0+0/tsort.rb:350:in `block (2 levels) in each_strongly_connected_component'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/3.3.0+0/tsort.rb:431:in `each_strongly_connected_component_from'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/3.3.0+0/tsort.rb:349:in `block in each_strongly_connected_component'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/gems/3.3.0+0/gems/rbs-3.0.3/lib/rbs/definition_builder/method_builder.rb:73:in `each_value'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/gems/3.3.0+0/gems/rbs-3.0.3/lib/rbs/definition_builder/method_builder.rb:73:in `tsort_each_node'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/3.3.0+0/tsort.rb:347:in `call'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/3.3.0+0/tsort.rb:347:in `each_strongly_connected_component'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/3.3.0+0/tsort.rb:316:in `each_strongly_connected_component'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/gems/3.3.0+0/gems/rbs-3.0.3/lib/rbs/definition_builder/method_builder.rb:51:in `each'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/gems/3.3.0+0/gems/rbs-3.0.3/lib/rbs/definition_builder.rb:579:in `import_methods'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/gems/3.3.0+0/gems/rbs-3.0.3/lib/rbs/definition_builder.rb:248:in `block (2 levels) in build_singleton0'
	from <internal:kernel>:90:in `tap'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/gems/3.3.0+0/gems/rbs-3.0.3/lib/rbs/definition_builder.rb:225:in `block in build_singleton0'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/gems/3.3.0+0/gems/rbs-3.0.3/lib/rbs/definition_builder.rb:751:in `try_cache'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/gems/3.3.0+0/gems/rbs-3.0.3/lib/rbs/definition_builder.rb:218:in `build_singleton0'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/gems/3.3.0+0/gems/rbs-3.0.3/lib/rbs/definition_builder.rb:302:in `block (2 levels) in build_singleton'
	from <internal:kernel>:90:in `tap'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/gems/3.3.0+0/gems/rbs-3.0.3/lib/rbs/definition_builder.rb:301:in `block in build_singleton'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/gems/3.3.0+0/gems/rbs-3.0.3/lib/rbs/definition_builder.rb:751:in `try_cache'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/gems/3.3.0+0/gems/rbs-3.0.3/lib/rbs/definition_builder.rb:294:in `build_singleton'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/gems/3.3.0+0/gems/rbs-3.0.3/lib/rbs/cli.rb:453:in `block in run_validate'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/gems/3.3.0+0/gems/rbs-3.0.3/lib/rbs/cli.rb:448:in `each'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/gems/3.3.0+0/gems/rbs-3.0.3/lib/rbs/cli.rb:448:in `run_validate'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/gems/3.3.0+0/gems/rbs-3.0.3/lib/rbs/cli.rb:135:in `run'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/lib/ruby/gems/3.3.0+0/gems/rbs-3.0.3/exe/rbs:7:in `<top (required)>'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/bin/rbs:25:in `load'
	from /Users/kuwabara.masataka/.rbenv/versions/trunk/bin/rbs:25:in `<main>'

I've confirmed the following code does not raise the error.

module M
  def f: () -> void
end

# Overload included instance method
class C2
  include M
  def f: () -> void | ...
end

class Parent
  def self.f: () -> Integer
  def f: () -> Integer
end

# Overload superclass's singleton method
class C3 < Parent
  def self.f: () -> void | ...
end

# Overload superclass's instance method.
class C4 < Parent
  def f: () -> void | ...
end

And I also confirmed this problem occurs on rbs v3.0.3 but not on v3.0.2.

I got this problem on ActiveJob and ActiveRecord.
https://github.com/ruby/gem_rbs_collection/blob/6751bcb8010ea20e2a7838e92264a122e1d42c79/gems/activejob/6.0/activejob.rbs#L12
https://github.com/ruby/gem_rbs_collection/blob/6751bcb8010ea20e2a7838e92264a122e1d42c79/gems/activerecord/6.0/activerecord.rbs#L56C6-L59

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions