support Ruby 2.4's frozen string literals (on master) #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
changed the title
This was referenced Jun 23, 2017
|
This looks fine to me... CI failure is not related as best I can tell... I would feel better if the CI were configured to include 2.4. |
|
Looks fine to me. |
alexdowad
approved these changes
Sep 15, 2017
Note this change is made relative to master.
flavorjones
force-pushed
the
flavorjones-master-frozen-string-literal
branch
from
bc3aa11 to
830ba4a
Compare
for ruby 2.4 and higher, to prevent regressing on frozen literal support.
flavorjones
force-pushed
the
flavorjones-master-frozen-string-literal
branch
from
830ba4a to
3f8e7f3
Compare
|
Merging onto master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this change is made relative to master.
To test before/after, set
RUBYOPT="--enable-frozen-string-literal --debug=frozen-string-literal"