Skip to content

Fix RestrictedYAMLTree allowing the Symbol class should allow all symbols #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2023
Merged

Fix RestrictedYAMLTree allowing the Symbol class should allow all symbols #617

merged 1 commit into from
Jan 23, 2023

Conversation

@casperisfine
Copy link

@casperisfine casperisfine commented Jan 22, 2023

Ref: #495

That's how it works for safe_load:

>> YAML.safe_load(':foo', permitted_classes: [Symbol])
=> :foo

So safe_dump should mirror that.

cc @tenderlove

@byroot
Fix RestrictedYAMLTree allowing the Symbol class should allow all sym…
592a75a 
…bols

Ref: ruby#495

That's how it works for `safe_load`:
```ruby
>> YAML.safe_load(':foo', permitted_classes: [Symbol])
=> :foo
```

So `safe_dump` should mirror that.
@casperisfine casperisfine mentioned this pull request Jan 22, 2023
Merged
@tenderlove tenderlove merged commit ccf3b07 into ruby:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@casperisfine @tenderlove @byroot