-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we unbundle libyaml? #535
Comments
Is it related with libffi issue? Basically, I agree with unbundle it. But We should confirm to build psych with libyaml package provided by vcpkg in mswin environment. |
Just a heads up because we stumbled upon this while having the libyaml-dev package install on Ubuntu LTS. When unbundled or when the libyaml-dev package is installed will cause the whitespace issue (yaml/libyaml#186) on Ubuntu LTS again since it still uses an old version w/o the fix. |
We talked about unbundling libraries at the dev meeting, and I couldn't remember why we bundled libyaml.
I found the ticket here. I guess the problem is that RubyGems depends on Psych, and Psych depends on libyaml, so we need to make sure you can install Psych so that you can install RubyGems. Essentially you can't use RubyGems unless libyaml is installed.
If Ruby depends on RubyGems, and RubyGems depends on Psych, then Ruby depends on libyaml.
I don't like bundling libraries, but I don't think we should make a hard dependency on libyaml being installed. In other words, I think we should continue to embed libyaml unless there is a different solution.
Any opinions? @hsbt @unak
The text was updated successfully, but these errors were encountered: