Conversation
koic
force-pushed
the
resolve_conflict_for_prism_translation_parser_initialize
branch
from
0eda078 to
7c82ae5
Compare
koic
changed the title
Prism::Translation::Parser#initializePrism::Translation::Parser#initialize
paracycle
reviewed
Feb 25, 2025
lib/prism/translation/parser.rb
Outdated
|
|
||
| Racc_debug_parser = false # :nodoc: | ||
|
|
||
| # The `builder` argument is used to create the parser using out custom builder class by default. |
Collaborator
There was a problem hiding this comment.
Should this be:
Suggested change
| # The `builder` argument is used to create the parser using out custom builder class by default. | |
| # The `builder` argument is used to create the parser using our custom builder class by default. |
Contributor
Author
There was a problem hiding this comment.
Oops! I've fixed this typo. Thank you, Ufuk!
This restores the missing method comments in ruby#3479.
koic
force-pushed
the
resolve_conflict_for_prism_translation_parser_initialize
branch
from
7c82ae5 to
78b8f67
Compare
kddnewton
approved these changes
Feb 25, 2025
koic
deleted the
resolve_conflict_for_prism_translation_parser_initialize
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores the missing method comments in #3479.