Modify build-artifacts.yml to package libprism source instead#3391
Merged
Modify build-artifacts.yml to package libprism source instead#3391
build-artifacts.yml to package libprism source instead#3391Conversation
Instead of uploading the built `libprism.so` and `libprism.dylib`, which still requires headers files to be built, Prism can upload the full source, headers, and the Makefile as a tarball that can be used to build libprism from source. The reason default release artifacts are not enough is because some source and header files are generated through Prism's rake tasks.
st0012
force-pushed
the
add-libprism-artifacts
branch
from
52eb0e0 to
b8258ca
Compare
paracycle
approved these changes
Jan 10, 2025
Collaborator
paracycle
left a comment
paracycle
left a comment
There was a problem hiding this comment.
Looks good to me, thank you!
st0012
commented
Jan 10, 2025
| matrix: | ||
| os: [ubuntu-latest, macos-latest] | ||
| runs-on: ${{ matrix.os }} | ||
| runs-on: ubuntu-latest |
Member
Author
There was a problem hiding this comment.
Since we're not building binary files anymore, we don't need to run this on multiple systems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of uploading the built
libprism.soandlibprism.dylib, which still requires headers files to be built, Prism can upload the full source, headers, and the Makefile as a tarball that can be used to buildlibprismfrom source.The reason default release artifacts are not enough is because some source and header files are generated through Prism's rake tasks.
Example release: https://github.com/Shopify/prism/releases/tag/v1.3.2
Note: This is @paracycle's brilliant idea 🚀