Reject pattern match with unexpected double splat inside array#3382
Merged
eileencodes merged 1 commit intoruby:mainfrom Jan 8, 2025
Merged
Reject pattern match with unexpected double splat inside array#3382eileencodes merged 1 commit intoruby:mainfrom
eileencodes merged 1 commit intoruby:mainfrom
Conversation
`a => [-2**b]` should be SyntaxError Fixes: ruby#3381
eileencodes
approved these changes
Jan 8, 2025
Collaborator
|
This seems to have some unintended consequence: https://github.com/ruby/ruby/actions/runs/12675763001/job/35327482624 [-2**32,2**32]
=> [4294967296, 4294967296] # Both are positive |
Collaborator
|
I've opened a PR to revert this. Unfortunately doing this in the general expression parser does not take into account that this is a pattern match and should be rejected. We can't solve this in that place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a => [-2**b]should be SyntaxErrorFixes: #3381