Skip to content

Make location methods thread-safe #2432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eregon merged 1 commit into from
Feb 15, 2024
Merged

Make location methods thread-safe #2432

eregon merged 1 commit into from
Feb 15, 2024

Conversation

@eregon
Copy link
Member

@eregon eregon commented Feb 15, 2024

@eregon
Make location methods thread-safe
ff762dc 
* Before it could result in NoMethodError if multiple threads were
  calling location methods: https://gist.github.com/eregon/b78b7f266d7ee0a278a389cfd1782232
@eregon eregon requested a review from kddnewton February 15, 2024 22:27
kddnewton
kddnewton approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@kddnewton kddnewton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@eregon eregon merged commit c539857 into ruby:main Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kddnewton kddnewton kddnewton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eregon @kddnewton