Use templating to avoid duplicating the YARP version in many places#1295
Merged
Use templating to avoid duplicating the YARP version in many places#1295
Conversation
eregon
force-pushed
the
version-in-template
branch
2 times, most recently
from
03d71bd to
ee8365c
Compare
eregon
commented
Aug 21, 2023
eregon
force-pushed
the
version-in-template
branch
2 times, most recently
from
4542f78 to
79fcb3d
Compare
eregon
commented
Aug 21, 2023
| run: | | ||
| bundle install | ||
| rm -rf lib ext # ensure we don't use the local files | ||
| git checkout lib/yarp/version.rb # we need version.rb to load the gemspec |
Member
Author
There was a problem hiding this comment.
Either this or we need to move the version outside of lib ext due to the line above.
eregon
force-pushed
the
version-in-template
branch
from
79fcb3d to
9c359fd
Compare
kddnewton
approved these changes
Aug 25, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is only two places left which duplicate the version:
Gemfile.lock:4: yarp (0.8.0)Seems unavoidable.
rust/yarp-sys/tests/utils_tests.rs:15: assert_eq!(&cstring.to_string_lossy(), "0.8.0");Not sure how to get the version there.