ResponseParser docs #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 21, 2022
nevans
force-pushed
the
response-parser-docs
branch
2 times, most recently
from
421309e to
66863a1
Compare
Collaborator
Author
|
@shugo: the reference to |
nevans
force-pushed
the
response-parser-docs
branch
from
66863a1 to
e500d28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no reason not to include at least very basic user-visible docs for ResponseParser. I've been using Net::IMAP::ResponseParser (both separate from and combined with the rest of the Net::IMAP client, both my forked version and the upstream version) for over a decade. 😄
Also, I want to consider adding some parser options, e.g. "#{provider} quirks mode" vs "strict mode" vs "support experimental draft rfc", and it would make the most sense to document options those here.