✅ Fix issues with simplecov v1.0 upgrade - #721
Merged
Merged
Conversation
nevans
force-pushed
the
fix-simplecov-upgrade
branch
from
July 22, 2026 17:59
10f5371 to
39a267f
Compare
I think this was originally in test/lib/helper.rb for some strange reason having to do with circular dependencies or some-such. But, now that simplecov v1.0 has pulled in the HTML and JSON formatters as part of the core gem, that's no longer an issue.
In addition to the obvious changes (which had deprecation warnings): * The HTML formatter includes the JSON formatter, so only the HTML formatter is used now. * Use default simplecov primary_coverage. I think I misunderstood how that was being measured before. I wanted a count that _combines_ lines and branches into a single number.
`joshmfrankel/simplecov-check-action` is broken with simplecov v1.0. And simplecov can handle minimum coverage requirements on its own now. `rake coverage:report` prints out the (already collected) coverage stats and returns an error status when the minimum requirements aren't met.
nevans
force-pushed
the
fix-simplecov-upgrade
branch
from
July 23, 2026 18:27
416a120 to
e38a03d
Compare
nevans
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a few issues that came from upgrading to v1.0 (in #718), one of which was identified by #717, but I didn't notice those issues until after merging both. Oops!
This updates the simplecov config in several ways:
Note that normal test runs will not trigger any coverage requirements.
Run
rake coverage:reportto trigger an error on low coverage.ratchets up the minimum coverage requirements to current level(will do in another PR)to allow higher minimum coverage per file, this adds some exceptions for outlier files.(will do in another PR)adds minimum coverage criteria for each group(will do in another PR)A future PR will ratchet up the minimum coverage requirements and bring back something similar to
joshmfrankel/simplecov-check-action. But this should be good enough for now.