🔍 Improve Config#pretty_print (for Kernel::pp)#547
Merged
Conversation
nevans
force-pushed
the
config/pretty_print
branch
from
bd3c74a to
85957ff
Compare
Viewing config objects in Irb was _much_ too messy to easily inspect: it printed every attribute for each ancestor, and most of them would simply be the Net::IMAP::Config::AttrInheritance::INHERITED const, repeated over and over. So, just like `Config#inspect` was improved by #546, this simplifies the `Kernel#pp` output to make it more useful for inspection on the console. Unlike `Config#inspect`, `Config#pretty_print` prints _every_ config attribute, including attributes that have been defined by a named default config. Like `Config#inspect`, each attributes is printed only once, nested in the config which assigned it.
nevans
force-pushed
the
config/pretty_print
branch
from
85957ff to
2cc2acc
Compare
Collaborator
Author
|
Tests are only failing in windows for ruby-head due to:
Those fixes should all be merged shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Viewing config objects in Irb was much to messy to easily inspect: it printed every attribute for each ancestor, and most of them would simply be the Net::IMAP::Config::AttrInheritance::INHERITED const, repeated over and over.
So, just like
Config#inspectwas improved by #546, this simplifies theppoutput to make it more useful for inspection on the console.Unlike
Config#inspect,Config#pretty_printprints every config attribute, including attributes that have been defined by a named default config.