Merged
Conversation
Collaborator
Author
|
Although I first wrote this to simply enforce the config values, I'd prefer to allow the old config values (for backward compatibility) but print a warning when they are set to anything other than the new default. I'd print the warning once per parser instance (set |
nevans
force-pushed
the
drop-uidplus_datauid
branch
from
1c169f8 to
2758d0a
Compare
nevans
force-pushed
the
drop-uidplus_datauid
branch
from
2758d0a to
70d57d7
Compare
nevans
force-pushed
the
drop-uidplus_datauid
branch
from
70d57d7 to
a864e0d
Compare
nevans
force-pushed
the
drop-uidplus_datauid
branch
2 times, most recently
from
bd61792 to
6763a7a
Compare
nevans
force-pushed
the
drop-uidplus_datauid
branch
from
6763a7a to
67b37c2
Compare
The configuration options remain, until 0.7, so that code using those config options doesn't immediately break upon upgrade. The response parser will print a warning every time an `APPENDUID` or `COPYUID` response code is parsed. The warning includes instructions for silencing the itself.
nevans
force-pushed
the
drop-uidplus_datauid
branch
from
67b37c2 to
1c5d21a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #539 being merged first.