✅ Fix flaky tests with FakeServer#Connection#close mutex
#520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this was getting triggered from multiple threads: * from `FakeServer#shutdown` (which already has a mutex of its own) * called in ensure clause in `FakeServer#run` (from the server thread) * called directly by the tests (from the main thread) * from the ensure clause in `Connection#run` (runs in the server thread) So the main thread could call `FakeServer#shutdown` while the server thread is handling the ensure clause in `Connection#run`. Adding a mutex to `Connection#close` should fix the flaky tests.
nevans
force-pushed
the
fix-flaky-fake_server-connection-close
branch
from
4c06a5f to
2c49cfa
Compare
nevans
added
tests-only
and removed
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.