Skip to content

🔎 Update SequenceSet#inspect format to Net::IMAP::SequenceSet(str) #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nevans merged 2 commits into from
Jul 21, 2025
Merged

🔎 Update SequenceSet#inspect format to Net::IMAP::SequenceSet(str) #501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6aa94c7
♻️📚 Refactor and document SequenceSet#inspect
nevans Jul 18, 2025
35ff9ef
🔎 Update SequenceSet#inspect output format
nevans Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions lib/net/imap/sequence_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1630,13 +1630,27 @@ def normalized_string
@tuples.empty? ? nil : -@tuples.map { tuple_to_str _1 }.join(",")
end

# Returns an inspection string for the SequenceSet.
#
# Net::IMAP::SequenceSet.new.inspect
# #=> "Net::IMAP::SequenceSet()"
#
# Net::IMAP::SequenceSet(1..5, 1024, 15, 2000).inspect
# #=> 'Net::IMAP::SequenceSet("1:5,15,1024,2000")'
#
# Frozen sets have slightly different output:
#
# Net::IMAP::SequenceSet.empty.inspect
# #=> "Net::IMAP::SequenceSet.empty"
#
# Net::IMAP::SequenceSet[1..5, 1024, 15, 2000].inspect
# #=> 'Net::IMAP::SequenceSet["1:5,15,1024,2000"]'
#
def inspect
if empty?
(frozen? ? "%s.empty" : "#<%s empty>") % [self.class]
elsif frozen?
"%s[%p]" % [self.class, to_s]
(frozen? ? "%s.empty" : "%s()") % [self.class]
else
"#<%s %p>" % [self.class, to_s]
(frozen? ? "%s[%p]" : "%s(%p)") % [self.class, to_s]
end
end

Expand Down
8 changes: 4 additions & 4 deletions test/net/imap/test_sequence_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,11 +888,11 @@ def obj.to_sequence_set; 192_168.001_255 end

data(
# desc => [expected, input, freeze]
"empty" => ["#<Net::IMAP::SequenceSet empty>", nil],
"empty" => ["Net::IMAP::SequenceSet()", nil],
"frozen empty" => ["Net::IMAP::SequenceSet.empty", nil, true],
"normalized" => ['#<Net::IMAP::SequenceSet "1:2">', [2, 1]],
"denormalized" => ['#<Net::IMAP::SequenceSet "2,1">', "2,1"],
"star" => ['#<Net::IMAP::SequenceSet "*">', "*"],
"normalized" => ['Net::IMAP::SequenceSet("1:2")', [2, 1]],
"denormalized" => ['Net::IMAP::SequenceSet("2,1")', "2,1"],
"star" => ['Net::IMAP::SequenceSet("*")', "*"],
"frozen" => ['Net::IMAP::SequenceSet["1,3,5:*"]', [1, 3, 5..], true],
)
def test_inspect((expected, input, freeze))
Expand Down
Loading