Skip to content

♻️ Avoid unnecessary allocation in SequenceSet[] #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nevans merged 1 commit into from
Jun 18, 2025
Merged

♻️ Avoid unnecessary allocation in SequenceSet[] #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions lib/net/imap/sequence_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,11 +390,8 @@ class << self
# Related: ::new, ::try_convert
def [](first, *rest)
if rest.empty?
if first.is_a?(SequenceSet) && first.frozen? && first.valid?
first
else
new(first).validate.freeze
end
set = try_convert(first)&.validate
set&.frozen? ? set : (set&.dup || new(first).validate).freeze
else
new(first).merge(*rest).validate.freeze
end
Expand Down
11 changes: 11 additions & 0 deletions test/net/imap/test_sequence_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,17 @@ def compare_to_reference_set(nums, set, seqset)
test ".[frozen SequenceSet] returns that SequenceSet" do
frozen_seqset = SequenceSet[123..456]
assert_same frozen_seqset, SequenceSet[frozen_seqset]

coercible = Object.new
frozen_seqset = SequenceSet[192, 168, 1, 255]
coercible.define_singleton_method(:to_sequence_set) { frozen_seqset }
assert_same frozen_seqset, SequenceSet[coercible]

coercible = Object.new
mutable_seqset = SequenceSet.new([192, 168, 1, 255])
coercible.define_singleton_method(:to_sequence_set) { mutable_seqset }
assert_equal mutable_seqset, SequenceSet[coercible]
refute_same mutable_seqset, SequenceSet[coercible]
end

test ".new, input may be empty" do
Expand Down