Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention behavior when logdev is a nil in the document #49

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Mention behavior when logdev is a nil in the document #49

merged 2 commits into from
Mar 31, 2020
+3 −2

Conversation

pocke
Copy link
Member

@pocke pocke commented Mar 30, 2020

We can make a logger that does nothing by Logger.new(nil), but it is not documented.
This pull request adds a mention of the behavior.

sonots
sonots reviewed Mar 30, 2020
View reviewed changes
Copy link
Member

@sonots sonots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File::NULL is also acceptable now

@pocke
Copy link
Member Author

pocke commented Mar 31, 2020

I added File::NULL also.
2e77277
Thanks!

sonots
sonots approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@sonots sonots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@sonots sonots merged commit bffc76a into ruby:master Mar 31, 2020
@pocke pocke deleted the nil-logdev-doc branch March 31, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonots sonots sonots approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pocke @sonots