Enable frozen_string_literal: true in logger.rb.

[ioquatix]

Is there any reason not to do this?

[ioquatix]

@sonots what do you think of this?

[sonots]

I remember the frozen_string_literal: false line was introduced to all (most of) standard libraries when it was introduced into ruby.

Also, I remember that I merged .freeze patch before. You should be able to remove them

logger/lib/logger.rb

Line 240 in 2dc832e

ProgName = "#{name}/#{rev}".freeze

Logically thinking, frozen_string_literal should be able to be true as long as we do not have a string mutated like a = ''; a << 'foo' (it is one example, though).
We need to examine (It looks it is okay changing to true with my hurried look).

[ioquatix]

I cannot find any example of mutable string and all tests pass so I think this is okay.

[ioquatix]

Because frozen_string_literal: true is only advisory, I don't believe we should remove .freeze. But please advise me on what you want and I can do it.

[sonots]

Please remove unnecessary .freeze if we change to frozen_string_literal: true because they are unnecessary.

[sonots]

Also, I want to make frozen_string_literal: true for all lib files in this library for consistency.

[sonots]

I will take care of others, let me merge.

[ioquatix]

Sorry I was sleeping but everything you did looks good!