Skip to content

Commit

Permalink
Benchmark Oj::Parser in a thread safe way
Browse files Browse the repository at this point in the history
The documentation state `Oj::Parser.usual` isn't thread safe:
https://github.com/ohler55/oj/blob/c70bf4125b546bc7146840b15de36460d42b4dff/ext/oj/parser.c#L1507-L1513

As such we shouldn't benchark it this way, but instantiate a new
parser every time. Technically in real world scenarios you could
create a pool of parsers and re-use them, but if it's not provided
by the gem, I'm not sure we should go out of our way to do it.
  • Loading branch information
byroot committed Nov 8, 2024
1 parent b1397e2 commit 855563f
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions benchmark/parser.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def benchmark_parsing(name, json_output)
Benchmark.ips do |x|
x.report("json") { JSON.parse(json_output) } if RUN[:json]
x.report("oj") { Oj.load(json_output) } if RUN[:oj]
x.report("Oj::Parser") { Oj::Parser.usual.parse(json_output) } if RUN[:oj]
x.report("Oj::Parser") { Oj::Parser.new(:usual).parse(json_output) } if RUN[:oj]
x.report("rapidjson") { RapidJSON.parse(json_output) } if RUN[:rapidjson]
x.compare!(order: :baseline)
end
Expand All @@ -28,10 +28,6 @@ def benchmark_parsing(name, json_output)

# NB: Notes are based on ruby 3.3.4 (2024-07-09 revision be1089c8ec) +YJIT [arm64-darwin23]

# Oj::Parser is significanly faster (~1.3x) on the next 3 micro-benchmarks in large part because its
# cache is persisted across calls. That's not something we can do with the current API, we'd
# need to expose a stateful API as well, but that's no really desirable.
# Other than that we're faster than regular `Oj.load` by a good margin (between 1.3x and 2.4x).
benchmark_parsing "small nested array", JSON.dump([[1,2,3,4,5]]*10)
benchmark_parsing "small hash", JSON.dump({ "username" => "jhawthorn", "id" => 123, "event" => "wrote json serializer" })
benchmark_parsing "test from oj", <<JSON
Expand Down

0 comments on commit 855563f

Please sign in to comment.