update test to check for UTF16LE/BE #1132
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderadam
force-pushed
the
add_additional_encoding_tests
branch
from
53acae1 to
078782c
Compare
tompng
reviewed
Oct 30, 2025
test/irb/test_completion.rb
Outdated
Comment on lines
352
to
356
| if RUBY_ENGINE != 'truffleruby' | ||
| test_obj.define_singleton_method("test_utf16_method".encode(Encoding::UTF_16)) {} | ||
| end | ||
| test_obj.define_singleton_method("test_utf16le_method".encode(Encoding::UTF_16LE)) {} | ||
| test_obj.define_singleton_method("test_utf16be_method".encode(Encoding::UTF_16BE)) {} |
There was a problem hiding this comment.
Only testing one of UTF_16LE or UTF_16BE is enough.
As mentioned in #1129 (comment), UTF_16 is a dummy encoding. Testing UTF_16 is not so important. There's a benefit removing UTF_16 test: removing truffleruby condition.
Here's a list of encodings that cause error. It is not restricted to UTF_16 family.
UTF-16BE UTF-16LE UTF-32BE UTF-32LE UTF-16 UTF-32 CP949 Emacs-Mule
EUC-TW Windows-1258 GB1988 macCentEuro macThai IBM037 stateless-ISO-2022-JISO-2022-JP
CP50220 CP50221 MacJapanese ISO-2022-JP-KDDI stateless-ISO-2022-JP-KDDI
Found by this script
Encoding.list.each do |encoding|
obj = Object.new
(128..0xffff).each do |c|
obj.define_singleton_method('a'.encode(encoding) + c.chr(encoding)){}
rescue EncodingError, RangeError
end
IRB::RegexpCompletor.new.completion_candidates('', 'obj.a', '', bind: binding) rescue puts encoding.name
endI don't think it's worth testing all of these encodings.
So I think selecting one of them (UTF_16LE or UTF_16BE) is enough.
There was a problem hiding this comment.
Got it.
Thank you again for the explanation. I updated the test to only check for UTF-16LE now
alexanderadam
force-pushed
the
add_additional_encoding_tests
branch
from
078782c to
7af1008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just extends the test for UTF-16 LE/BE as well.
refs #52 and #1129 (comment)
PS: I'm looking for a new adventure in case anybody is looking to hire or work with a Ruby/Rails/Crystal dev
PPS: would you be so kind and add the
hacktoberfest-acceptedlabel to this issue in case you find that PR helpful? 🥺