Skip to content

Conversation

@G-Rath
Copy link

@G-Rath G-Rath commented Dec 23, 2025

These methods are meant to be overridden, but have default implementations which return false for convenience which has resulted in the generator typing their returns as false rather than bool

Resolves #955

@github-actions
Copy link

@G-Rath Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

activemodel

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@hibariya, @ksss, @tk0miya, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

@ksss
Copy link
Collaborator

ksss commented Dec 24, 2025

@tk0miya
I'm not familiar with type narrowing, but could this change potentially have negative impacts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confused over persisted? type for ActiveModel

2 participants