Fixed bug with rejecting correct value in spell checker. Fixed #121 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Overall this looks great, and I think we can merge with a few minor changes. |
yuki24
reviewed
Nov 18, 2019
|
|
||
| private | ||
|
|
||
| def similar_keys |
There was a problem hiding this comment.
I would call this method exact_matches as it describes what it does better.
yuki24
reviewed
Nov 18, 2019
| @@ -8,7 +8,13 @@ def initialize(key_error) | |||
| end | |||
|
|
|||
| def corrections | |||
| @corrections ||= SpellChecker.new(dictionary: @keys).correct(@key).map(&:inspect) | |||
| @corrections ||= similar_keys + SpellChecker.new(dictionary: @keys).correct(@key).map(&:inspect) | |||
There was a problem hiding this comment.
I think it makes more sense to only suggest exact matches if they are present, then fall back to the typical spell checking approach. That should by design prevent inaccurate suggestions from creeping into the final results.
Suggested change
| @corrections ||= similar_keys + SpellChecker.new(dictionary: @keys).correct(@key).map(&:inspect) | |
| @corrections ||= exact_matches.empty? ? SpellChecker.new(dictionary: @keys).correct(@key).map(&:inspect) : exact_matches |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.