Fixes for promotion to default gem #132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things are going wrong in the test suite for ruby core ruby/ruby#2631. This attempts to fix both.
assert_raises
throws a NoMethodError from within ruby core. Not sure why? It says to useassert_raise
so that what I've gone and replaced everything with. Test suite still passes just fine so I imagine it's an alias in some versions of test/unit and not in others. Weird.For the second point there, I'm not sure if that means there's something that should be done in Ruby core, but this will certainly fix it for just DYM.