Mention Ruby version requirement in Readme#500
Merged
ko1 merged 2 commits intoruby:masterfrom Feb 21, 2022
Merged
Conversation
c1f18cd to
373038b
Compare
ko1
reviewed
Feb 5, 2022
Co-authored-by: Koichi Sasada <ko1@atdot.net>
256e92e to
952a781
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got feedback from Rubyists saying that they thought the debugger only works with Ruby 3.1. Given that it's mostly advertised with the Ruby 3.1 release, I can understand why they make that assumption. So I think we can mention the supported Ruby version and platform in the readme to make it clearer.