Merged
Conversation
ko1
reviewed
Feb 5, 2022
st0012
force-pushed
the
support-command-on-check-bp
branch
from
3cb98ad to
d528dcf
Compare
By requiring all subclasses to pass cond, command, and path explicitly, it should reduce the chance to miss support on them (or new options).
st0012
force-pushed
the
support-command-on-check-bp
branch
from
d528dcf to
8786af7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
break if: conddoesn't support commands likedo:orpre:. This PR adds the support.Breakpoint's options processing to the parent class as keyword arguments. This requires the options (path,commandandcondfor now) to be explicitly provided. It should make missing support of them more noticeable.