Fix bug that debugger sometimes doesn't open Chrome automatically#445
Merged
ko1 merged 1 commit intoruby:masterfrom Dec 17, 2021
Merged
Fix bug that debugger sometimes doesn't open Chrome automatically#445ko1 merged 1 commit intoruby:masterfrom
ko1 merged 1 commit intoruby:masterfrom
Conversation
The reason is that the debugger doesn't wait for the response of 'Page.navigate' method
ono-max
referenced
this pull request
in ono-max/debug
Dec 18, 2021
#445 was an ad hoc solution and this commit fixes it correctly The reason of the bug is that the debugger doesn't call 'Page.enable'
Merged
ko1
pushed a commit
that referenced
this pull request
Dec 18, 2021
#445 was an ad hoc solution and this commit fixes it correctly The reason of the bug is that the debugger doesn't call 'Page.enable'
ono-max
referenced
this pull request
in ono-max/debug
Dec 23, 2021
Chrome sometimes fails to get the frame id when it navigates current page to the given URL This is related to #445
ono-max
referenced
this pull request
in ono-max/debug
Dec 23, 2021
Chrome sometimes fails to get the frame id when it navigates current page to the given URL This is related to #445
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debugger sometimes doesn't open Chrome automatically because the debugger doesn't wait for the response of 'Page.navigate' method. This PR fixes it.