Skip tests for DAP if the environmental variable is not set#433
Merged
ko1 merged 3 commits intoruby:masterfrom Dec 16, 2021
Merged
Skip tests for DAP if the environmental variable is not set#433ko1 merged 3 commits intoruby:masterfrom
ko1 merged 3 commits intoruby:masterfrom
Conversation
To embed debug.gem in ruby 3.1, we have to make tests passes. Because the current test framework for DAP is not stable, we'll skip tests for DAP as an ad hock way.
Member
|
Perhaps we can add a new workflow for DAP tests? We can also add |
Collaborator
|
it will be tested on ruby/ruby so we need to stop the unstable DAP test ASAP. |
Member
|
@ko1 yeah I understand that. my suggestion is to add a new job for the DAP tests (with the ENV enabled) so we can still get DAP tested on CI. |
Member
Author
|
@st0012
I agree with your opinion. Let me create the PR to add a new job for DAP tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To embed debug.gem in ruby 3.1, we have to make tests passes. Because the current test framework for DAP is not stable, we'll skip tests for DAP as an ad hock way.