Skip to content

Skip tests for DAP if the environmental variable is not set#433

Merged
ko1 merged 3 commits intoruby:masterfrom
ono-max:patch-4
Dec 16, 2021
Merged

Skip tests for DAP if the environmental variable is not set#433
ko1 merged 3 commits intoruby:masterfrom
ono-max:patch-4

Conversation

@ono-max
Copy link
Member

@ono-max ono-max commented Dec 14, 2021

To embed debug.gem in ruby 3.1, we have to make tests passes. Because the current test framework for DAP is not stable, we'll skip tests for DAP as an ad hock way.

To embed debug.gem in ruby 3.1, we have to make tests passes. Because the current test framework for DAP is not stable, we'll skip tests for DAP as an ad hock way.
@st0012
Copy link
Member

st0012 commented Dec 15, 2021

Perhaps we can add a new workflow for DAP tests? We can also add continue-on-error: true so when it failed the entire build would still be green.

@ko1 ko1 merged commit ce26e85 into ruby:master Dec 16, 2021
@ko1
Copy link
Collaborator

ko1 commented Dec 16, 2021

it will be tested on ruby/ruby so we need to stop the unstable DAP test ASAP.

@st0012
Copy link
Member

st0012 commented Dec 16, 2021

@ko1 yeah I understand that. my suggestion is to add a new job for the DAP tests (with the ENV enabled) so we can still get DAP tested on CI.

@ono-max ono-max deleted the patch-4 branch December 25, 2021 12:11
@ono-max
Copy link
Member Author

ono-max commented Dec 25, 2021

@st0012
Sorry for the late reply.

my suggestion is to add a new job for the DAP tests (with the ENV enabled) so we can still get DAP tested on CI.

I agree with your opinion. Let me create the PR to add a new job for DAP tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants