Add condition and command support to watch command#393
Merged
ko1 merged 5 commits intoruby:masterfrom Nov 25, 2021
Merged
Conversation
Member
Author
|
I think the binding for condition evaluation needs more work. |
st0012
commented
Nov 16, 2021
| @ivar = ivar.to_sym | ||
| @object = object | ||
| @key = [:watch, @ivar].freeze | ||
| @key = [:watch, object.object_id, @ivar].freeze |
Member
Author
There was a problem hiding this comment.
WatchBreakpoint could be initialized for multiple instances, so we should take that into consideration when filtering duplicated bps.
| @current = result | ||
| suspend | ||
|
|
||
| if @cond.nil? || @object.instance_eval(@cond) |
Member
Author
There was a problem hiding this comment.
IMO, the if condition of WatchBreakpoint should also be evaluated on the target object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
watchis the only breakpoint command that doesn't support condition and command options (if,do, andpre). It's not by design and the inconsistency between it and other commands may confuse the users. So after discussing with @ko1, we're supporting those options onwatchtoo.