Fix bug that breakpoints still left even though they are removed in Chrome#371
Merged
ko1 merged 3 commits intoruby:masterfrom Nov 8, 2021
Merged
Fix bug that breakpoints still left even though they are removed in Chrome#371ko1 merged 3 commits intoruby:masterfrom
ko1 merged 3 commits intoruby:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Breakpoints still left even though they are removed in Chrome #361
Description
#361 is not fixed completely because values of
bpsare not updated correctly and recent change. This PR fixes two parts as follows:bpswhen getting 'Debugger.removeBreakpoint'.