handle invalid encoding in the pure ruby version of CGI.escapeHTML and CGI.unescapeHTML #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahorek
changed the title
|
Can you please add a test that fails with the current code and is fixed by your changes? |
|
tests for both cases are in the description. It's still valid. |
|
You can write a test that in a setup block aliases CGI::Escape#escapeHTML to something else and removes the method, runs the test, and then aliases it back in a teardown block (skipping the test suite if CGI::Escape#escapeHTML is not defined). This will allow you to test the pure-ruby version while the extension is installed. Can you please add such a test so we can ensure ongoing automated tests of the pure ruby version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the pure ruby version should behave the same way as the native extension
spec ruby/spec#759 and ruby/spec#782
note that the failure can be observed only in case when the native extension can't be loaded or with alternative ruby implementations