Fix division rounding #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the intermediate calculation of `a.div(b, 4)` is `0.123000000 000000000 ...`, Round up result may be 0.1230 or 0.1231 depend on remainder of the division. Treat the calculation as `0.123000000 000000001` in such case to calculate rounding correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #328
Depend on #329
Rounding needs these two:
remaining digits == zeroThese are some rounding rules:
ROUND_HALF_UP:
next_digit>=5ROUND_HALF_DOWN:
next_digit>5 || (next_digit==5 && !remaining_zero)ROUND_UP:
next_digit>0 || !remaining_zeroCurrently, BigDecimal_div2 only uses next few digits.
This pull request adds extra information about remaining_digits before rounding.