Using Phlex::Kit to propose a new PhlexUI syntax #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New format
Instead of writing:
we will be able to use:
Or even better, like how Material UI is abbreviated to Mui, we should abbreviate PhlexUI to Pui for a shorter namespace. I have created a module to forward all requests from Pui to PhlexUI, but in the future, we should rename the PhlexUI module to Pui.
Testing
To be able to write better tests, I have created a
phlex_contextmethod insideTestHelperto be used for tests. That way, we can write Phlex syntax inside the tests. I also removed thetest/accordionbecause it wasn't testing much. We should be able to test everything insidetest/accordion_test.rb.Drop Builder support
Accordion has a "builder" that can create an accordion easily with a block syntax. @iseth and I agreed that this style shouldn't be promoted because it goes against the customization principle of Shadcn, hiding away parts of the component.
Fix ActiveSupport dependency
Fix the ActiveSupport dependency to allow PhlexUI to be used with Rails 6 and above. Previously, only Rails 6 was allowed.
If we agree with the changes here, I will be able to extend them to all other components! I would like to see a PhlexUI V1 soon in the future.
Thanks @joeldrapper for helping me out with Phlex::Kit