next command should respect the current frame's location#4
Open
st0012 wants to merge 1 commit intoruby-tooling:masterfrom
Open
next command should respect the current frame's location#4st0012 wants to merge 1 commit intoruby-tooling:masterfrom
st0012 wants to merge 1 commit intoruby-tooling:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
nextcommand aways move based on the most recent frame, even if the user already moved to upper frames. If thenextcommand would be locked into the deepest frame, it's usage would become very limited. So I consider this is a bug.Also, changing this will make this behavior align with
byebug, which is what most Rubyists are familiar with.Example
When debugging with
rdbg -e "b 12 ;; c ;; s ;; up ;; n" target.rb, I expect it to move like this:But currently it's like:
Before
After