Skip to content

Optimize pop nodes #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions lib/syntax_tree/yarv/sea_of_nodes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,30 @@ def cleanup_insn_nodes
connect_over(node)
remove(node)
end
when Pop
from = node.inputs.find { |edge| edge.type == :data }.from
next unless from.is_a?(InsnNode)

removed =
if from.inputs.empty? && from.outputs.size == 1
remove(from)
true
elsif from.insn.is_a?(Dup)
connect_over(from)
remove(from)

new_edge = node.inputs.last
new_edge.from.outputs.delete(new_edge)
node.inputs.delete(new_edge)
true
else
false
end

if removed
connect_over(node)
remove(node)
end
end
end
end
Expand Down