Skip to content

Return executable control after compile #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Return executable control after compile #209

wants to merge 1 commit into from

Conversation

jockofcode
Copy link

I need to call the rake compile task twice within our rake file, but because of the use of exec instead of system, control is never returned to our calling rake task. This patch allows control to go back to the calling process.

@localshred

@jockofcode jockofcode closed this Aug 21, 2014
@jockofcode jockofcode deleted the bg/return_control_after_compile branch August 21, 2014 21:00
@localshred
Copy link
Contributor

Closed? @jockofcode

@jockofcode
Copy link
Author

Looks like when you don't use exec, the next run will fail anyway. I think the exec instead of system might have been intentional.
I discovered it after I sent the PR, sorry about that :(

@jockofcode jockofcode restored the bg/return_control_after_compile branch August 22, 2014 15:14
@jockofcode jockofcode reopened this Aug 22, 2014
@jockofcode
Copy link
Author

In my calling code to protobuf, I was missing clean task before calling it again. This patch is indeed needed to be able to call back into it.
Thank you @localshred! :)

I would like to reopen this PR.

@liveh2o
Copy link
Contributor

liveh2o commented Aug 26, 2014

Should this be handling different exit codes? Is that something that exec is implicitly doing right now?

@localshred
Copy link
Contributor

I seem to remember that exec was necessary for the protoc command to function correctly (when things fail). You'll want to verify that. If so, you'll need to fork instead @jockofcode

@localshred
Copy link
Contributor

...Meaning use the fork command, not fork the repo. 😉

@liveh2o
Copy link
Contributor

liveh2o commented Sep 7, 2014

#211 makes the change from exec to system. Closing this to avoid unnecessary merge conflicts.

@liveh2o liveh2o closed this Sep 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants