Skip to content

Release v0.12 #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 21, 2015
Merged

Release v0.12 #219

merged 5 commits into from
Sep 21, 2015

Conversation

jch
Copy link
Member

@jch jch commented Sep 18, 2015

cc @ruby-ldap/ruby-ldap-admins

@@ -1,5 +1,5 @@
module Net
class LDAP
VERSION = "0.11"
VERSION = "0.12"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't Semantic Versioning adopted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satoryu do you just mean why we're missing the patch number?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 98d122d. Thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jch added a commit that referenced this pull request Sep 21, 2015
@jch jch merged commit d27c084 into master Sep 21, 2015
@jch jch deleted the release-v0.12 branch September 21, 2015 14:10
@jch
Copy link
Member Author

jch commented Sep 21, 2015

@satoryu thanks for the review!

@jch jch mentioned this pull request Oct 27, 2015
astratto pushed a commit to astratto/ruby-net-ldap that referenced this pull request Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants