Skip to content

Fix test_unresponsive_host #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2014
Merged

Conversation

sonOfRa
Copy link
Contributor

@sonOfRa sonOfRa commented Nov 12, 2014

While working on my TLS options and running the tests, I noticed that this test failed.

When the host doesn't respond, the correct exception is thrown now.

@jch
Copy link
Member

jch commented Nov 12, 2014

👍

cc @mtodd @bnferguson fyi on this change. This won't affect our application because we rescue both Net::LDAP::LdapError and Errno::ETIMEDOUT, but the latter rescue is now redundant.

I'm merging this now because it is consistent with the current error code, but at some point, I'd like to pass through low level socket exceptions without wrapping them in a Net::LDAP class. We would have documentation explaining what errors to expect, but it's needlessly verbose to wrap each exception again in a Net::LDAP::LdapError.

jch added a commit that referenced this pull request Nov 12, 2014
@jch jch merged commit fc38d1c into ruby-ldap:master Nov 12, 2014
@bnferguson
Copy link

👍 Thanks for the heads up!

astratto pushed a commit to astratto/ruby-net-ldap that referenced this pull request Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants