[CI] Run specs and tests #119
Conversation
It works, but to be practical it's too slow to care about for now.
| - jruby-19mode | ||
| - rbx-19mode | ||
| # - rbx-2 |
There was a problem hiding this comment.
I'd like to drop official support for rbx for the 1.0 release as well, unless there's someone who's explicitly interested in supporting it. I don't think I can give it justice. Out of scope for this PR though.
There was a problem hiding this comment.
Was feeling the same while testing this out. I think we can keep the builds, but put them under allow_failures so we can keep an eye on it.
There was a problem hiding this comment.
👍 to allow_failures. Be good to add ruby-head in there as well to foresee future incompatibilities
There was a problem hiding this comment.
Also gonna punt on moving rbx to allowed failures/unofficial support.
There was a problem hiding this comment.
And by "unofficial support" I mean "not officially supported".
|
👍 |
[CI] Run specs and tests
While we move away from rspec and towards minitest, now seems like a good time to start running both to make sure builds don't break.
cc @jch @schaary