Fix transliteration to default replacement char #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romuloceccon
force-pushed
the
transliterate_non_ascii
branch
from
3352e10
to
77fedd7
Compare
Commit f6a4294 introduced a bug where non-ASCII chars not present in the transliteration map would be removed from the output, instead of being replaced by the default replacement char, violating the behavior stated in the documentation: I18n.transliterate("日本語") # => "" (should be "???") This fixes the issue while preserving the optimization introduced by that commit.
romuloceccon
force-pushed
the
transliterate_non_ascii
branch
from
77fedd7
to
6b60a5b
Compare
|
This is a perfect PR. I want to print it and frame it as an example to all PRs. I'll look at merging it a little later on today. |
|
Thanks for this quick fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit f6a4294 introduced a bug where non-ASCII chars not present in
the transliteration map would be removed from the output, instead of
being replaced by the default replacement char, violating the behaviour
stated in the documentation:
This fixes the issue while preserving the optimization introduced by
that commit.