Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fallbacks when translating key arrays #304

Closed
wants to merge 1 commit into from

Conversation

daniel-rikowski
Copy link

This fixes a problem when translating multiple keys at once. The (temporary) :fallback flag was not removed from the options parameter after successfully translating the first key. That way it "leaked" into the next iteration, which effectively disabled the fallback mechanism for all following keys.

This should fix #104 and #293.

end
ensure
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only real change: Putting the existing options.delete(:fallback) line in an ensure block. All other changes were caused by the new indentation level.

@airblade
Copy link

airblade commented Apr 1, 2016

Is anything stopping this from being merged?

@dchopson
Copy link

dchopson commented Jul 8, 2016

+1 my team needs this too

@radar
Copy link
Collaborator

radar commented Nov 15, 2016

Thanks very much for taking the time to fix this @daniel-rikowski. I am sorry that we weren't able to get around to merging it sooner.

Due to the conflicts on this branch, I've had to manually apply the PR to a branch called pr-304. Once the tests are green for that branch, then I will be merging that branch into master.

Thanks again for your time.

@radar radar added this to the 0.8.0 milestone Nov 15, 2016
@radar radar self-assigned this Nov 15, 2016
@radar radar mentioned this pull request Nov 15, 2016
@radar radar closed this in 1e47f92 Nov 15, 2016
@radar
Copy link
Collaborator

radar commented Nov 15, 2016

Brach is happy, and so am I :) This has now been merged to master. It'll go out in the 0.8.0 release (a beta of which should be out next month, with final release in the new year)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fallback error on t([])
4 participants