Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attributes with nil values should not be considered "missing". #864

Closed
wants to merge 1 commit into from
Closed

Attributes with nil values should not be considered "missing". #864

wants to merge 1 commit into from

Conversation

ppadron
Copy link
Contributor

@ppadron ppadron commented Dec 22, 2014

See #858.

dblock
dblock reviewed Dec 22, 2014
View reviewed changes
CHANGELOG.md
@@ -1,7 +1,7 @@
Next Release
============

* Your contribution here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put back this line! :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also note where those attributes are considered missing or not. This is about calling declared_params.

@dblock
Copy link
Member

dblock commented Dec 28, 2014

Merged via c51565c.

@dblock dblock closed this Dec 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ppadron @dblock