Validate array params against values #824
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dnd, looks good. Please fix rubocop warnings and update CHANGELOG/README, thanks! |
|
@dm1try, it should be good now. I just added an example in the README without changing any wording since this change makes something work that was probably expected to work. Let me know if you want to call the change out more specifically. |
|
@dm1try, I'm pretty sure Travis failing isn't my fault. The issues look to be bundler timeouts. Can you rerun it? |
|
Merged via 0df3bda. Travis is on the fritz with some of the configs, ... |
|
Thanks. When is the next release of Grape planned? |
|
I would really like a fix for #811 first, because that's a pretty major regression IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address issue #823. The code ensures that the acceptable values meet coercion of the array type, and then validates that passed in params are contained in the acceptable values list.