-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support lambda-based default values for params #510
Conversation
Very nice. Could you please update CHANGELOG and README, please via |
Sure will. Clearly being a bit slow here... but post |
You force-push it, |
:-( I feared as much. Ok, that should be done now. |
Check travis, you have offended the Rubocops :) |
@@ -12,6 +12,8 @@ Next Release | |||
* [#500](https://github.com/intridea/grape/pull/500): Skip entity auto-detection when explicitely passed - [@yaneq](https://github.com/yaneq). | |||
* Your contribution here. | |||
|
|||
#### Features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put Features
above, and move * Your contributions here.
into it, please.
README still needs the documentation that this construct supports lambdas. |
Sorry, sloppy work on the |
@dblock - is this now good to be pulled? Let me know if there is anything else outstanding. Much appreciated. |
Support lambda-based default values for params
Merged, good work. |
The test gives an example of what we're looking for here: