Allow parameters, such as content encoding, in content_type. #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a good change, could you update CHANGELOG please (via a |
|
@dblock , I'm not sure about description. It's more like a fix for POST/PUT requests with specific content type. |
| @@ -395,6 +395,27 @@ def app | |||
| last_response.body.should == '{"error":"The requested content-type \'application/xml\' is not supported."}' | |||
| end | |||
|
|
|||
| context 'context type with params' do | |||
There was a problem hiding this comment.
This should say 'content', not 'context'.
|
I think it should be something like "Allow parameters, such as content encoding, in |
| subject.format :json | ||
| subject.content_type :json, 'application/json; charset=utf-8' | ||
|
|
||
| subject.post '/request_body' do |
There was a problem hiding this comment.
Remove the path. So just subject.post do, the path is not necessary, so trying to write less code.
For example, if we define :json content type as "application/json; charset=utf-8" and client do payload(POST/PUT) request with "application/json" type then response should be successful. Ignore content type params in mime_types method.
|
Updated. |
dblock
added a commit
that referenced
this pull request
Nov 12, 2013
Allow parameters, such as content encoding, in content_type.
|
Thanks, merged. |
|
@dblock , thanks for helping me 💛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, if we define :json content type as "application/json; charset=utf-8"
and client do payload(POST/PUT) request with "application/json" type then response should be successful.
For now we have an error "The requested content-type 'application/json' is not supported".