Extend :cascade to work with all versioning strategies#342
Merged
dblock merged 1 commit intoruby-grape:masterfrom Feb 20, 2013
reliantsolutions:feature-cascade-for-all-versioning
Merged
Extend :cascade to work with all versioning strategies#342dblock merged 1 commit intoruby-grape:masterfrom reliantsolutions:feature-cascade-for-all-versioning
dblock merged 1 commit intoruby-grape:masterfrom
reliantsolutions:feature-cascade-for-all-versioning
Conversation
The :cascade option allows preventing X-Cascade to be returned on response headers. For Rails users, this is useful because your API exceptions don't get rendered/handled by Rails, but actually sent to users. This is particularly useful if you want your user to receive an error exception in the same format your API supports, and not an unexpected HTML page. A more in-depth explanation of :cascade was moved into the code and the overview was inserted on the main README on the exceptions section. This commit also changes the order in which versioning strategies are presented. The order is now consistent with the order in which the strategies were first presented. It also presents the default one, before introducing non-defaults.
Contributor
Author
|
As noted on #340, mounting Grape inside rails will likely get exceptions rendered by rails, which for some users may not be pleasant. By setting |
Member
|
I merged this with a small change: deleting the |
Contributor
Author
|
I first wrote is as deleting the header but for some reason I changed it to unsetting but I don't remember why :-( I'll try to remember. Hahaha |
Contributor
Author
|
BTW Did you run rspec with the header deleted? It might break the second test case I prepared. |
Member
|
I did fix the test ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The :cascade option allows preventing X-Cascade to be returned on
response headers. For Rails users, this is useful because your
API exceptions don't get rendered/handled by Rails, but actually sent to
users. This is particularly useful if you want your user to receive an
error exception in the same format your API supports, and not an
unexpected HTML page.
A more in-depth explanation of :cascade was moved into the code and the
overview was inserted on the main README on the exceptions section.
This commit also changes the order in which versioning strategies are
presented. The order is now consistent with the order in which the
strategies were first presented. It also presents the default one,
before introducing non-defaults.