Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Appraisals by eval_gemfile #2431

Merged
merged 2 commits into from
Apr 26, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 47 additions & 9 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 5000`
# on 2024-04-15 16:22:26 UTC using RuboCop version 1.59.0.
# on 2024-04-16 09:59:31 UTC using RuboCop version 1.63.2.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand Down Expand Up @@ -246,6 +246,52 @@ RSpec/VoidExpect:
- 'spec/grape/api_spec.rb'
- 'spec/grape/dsl/headers_spec.rb'

# Offense count: 598
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: ResponseMethods.
# ResponseMethods: response, last_response
RSpecRails/HaveHttpStatus:
ericproulx marked this conversation as resolved.
Show resolved Hide resolved
Exclude:
- 'spec/grape/api/custom_validations_spec.rb'
- 'spec/grape/api/deeply_included_options_spec.rb'
- 'spec/grape/api/defines_boolean_in_params_spec.rb'
- 'spec/grape/api/invalid_format_spec.rb'
- 'spec/grape/api/mount_and_helpers_order_spec.rb'
- 'spec/grape/api/mount_and_rescue_from_spec.rb'
- 'spec/grape/api/namespace_parameters_in_route_spec.rb'
- 'spec/grape/api/optional_parameters_in_route_spec.rb'
- 'spec/grape/api/parameters_modification_spec.rb'
- 'spec/grape/api/patch_method_helpers_spec.rb'
- 'spec/grape/api/required_parameters_in_route_spec.rb'
- 'spec/grape/api/required_parameters_with_invalid_method_spec.rb'
- 'spec/grape/api/routes_with_requirements_spec.rb'
- 'spec/grape/api/shared_helpers_exactly_one_of_spec.rb'
- 'spec/grape/api/shared_helpers_spec.rb'
- 'spec/grape/api_spec.rb'
- 'spec/grape/endpoint_spec.rb'
- 'spec/grape/exceptions/body_parse_errors_spec.rb'
- 'spec/grape/exceptions/invalid_accept_header_spec.rb'
- 'spec/grape/exceptions/validation_errors_spec.rb'
- 'spec/grape/extensions/param_builders/hash_spec.rb'
- 'spec/grape/extensions/param_builders/hash_with_indifferent_access_spec.rb'
- 'spec/grape/integration/global_namespace_function_spec.rb'
- 'spec/grape/integration/rack_spec.rb'
- 'spec/grape/middleware/error_spec.rb'
- 'spec/grape/middleware/exception_spec.rb'
- 'spec/grape/validations/params_scope_spec.rb'
- 'spec/grape/validations/validators/all_or_none_spec.rb'
- 'spec/grape/validations/validators/allow_blank_spec.rb'
- 'spec/grape/validations/validators/at_least_one_of_spec.rb'
- 'spec/grape/validations/validators/default_spec.rb'
- 'spec/grape/validations/validators/exactly_one_of_spec.rb'
- 'spec/grape/validations/validators/mutual_exclusion_spec.rb'
- 'spec/grape/validations/validators/presence_spec.rb'
- 'spec/grape/validations/validators/regexp_spec.rb'
- 'spec/grape/validations/validators/same_as_spec.rb'
- 'spec/grape/validations/validators/values_spec.rb'
- 'spec/grape/validations_spec.rb'
- 'spec/shared/versioning_examples.rb'

# Offense count: 1
# This cop supports unsafe autocorrection (--autocorrect-all).
Style/CombinableLoops:
Expand All @@ -259,14 +305,6 @@ Style/CombinableLoops:
Style/FormatStringToken:
EnforcedStyle: template

# Offense count: 1
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: AllowedReceivers.
# AllowedReceivers: Thread.current
Style/HashEachMethods:
Exclude:
- 'lib/grape/middleware/stack.rb'

# Offense count: 12
# Configuration parameters: AllowedMethods.
# AllowedMethods: respond_to_missing?
Expand Down
60 changes: 0 additions & 60 deletions Appraisals

This file was deleted.

17 changes: 8 additions & 9 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,12 @@ gemspec
group :development, :test do
gem 'bundler'
gem 'rake'
gem 'rubocop', '1.59.0', require: false
gem 'rubocop-performance', '1.20.1', require: false
gem 'rubocop-rspec', '2.25.0', require: false
gem 'rubocop', '1.63.2', require: false
gem 'rubocop-performance', '1.21.0', require: false
gem 'rubocop-rspec', '2.29.1', require: false
end

group :development do
gem 'appraisal'
gem 'benchmark-ips'
gem 'benchmark-memory'
gem 'guard'
Expand All @@ -25,11 +24,11 @@ end

group :test do
gem 'rack-contrib', require: false
gem 'rack-test', '< 2.1'
gem 'rspec', '< 4'
gem 'ruby-grape-danger', '~> 0.2.0', require: false
gem 'simplecov', '~> 0.21.2'
gem 'simplecov-lcov', '~> 0.8.0'
gem 'rack-test', '~> 2.1'
gem 'rspec', '~> 3.13'
gem 'ruby-grape-danger', '~> 0.2', require: false
gem 'simplecov', '~> 0.21'
gem 'simplecov-lcov', '~> 0.8'
gem 'test-prof', require: false
end

Expand Down
37 changes: 1 addition & 36 deletions gemfiles/dry_validation.gemfile
Original file line number Diff line number Diff line change
@@ -1,40 +1,5 @@
# frozen_string_literal: true

# This file was generated by Appraisal

source 'https://rubygems.org'
eval_gemfile '../Gemfile'

gem 'dry-validation'

group :development, :test do
gem 'bundler'
gem 'rake'
gem 'rubocop', '1.59.0', require: false
gem 'rubocop-performance', '1.20.1', require: false
gem 'rubocop-rspec', '2.25.0', require: false
end

group :development do
gem 'appraisal'
gem 'benchmark-ips'
gem 'benchmark-memory'
gem 'guard'
gem 'guard-rspec'
gem 'guard-rubocop'
end

group :test do
gem 'rack-contrib', require: false
gem 'rack-test', '< 2.1'
gem 'rspec', '< 4'
gem 'ruby-grape-danger', '~> 0.2.0', require: false
gem 'simplecov', '~> 0.21.2'
gem 'simplecov-lcov', '~> 0.8.0'
gem 'test-prof', require: false
end

platforms :jruby do
gem 'racc'
end

gemspec path: '../'
37 changes: 1 addition & 36 deletions gemfiles/grape_entity.gemfile
Original file line number Diff line number Diff line change
@@ -1,40 +1,5 @@
# frozen_string_literal: true

# This file was generated by Appraisal

source 'https://rubygems.org'
eval_gemfile '../Gemfile'

gem 'grape-entity'

group :development, :test do
gem 'bundler'
gem 'rake'
gem 'rubocop', '1.59.0', require: false
gem 'rubocop-performance', '1.20.1', require: false
gem 'rubocop-rspec', '2.25.0', require: false
end

group :development do
gem 'appraisal'
gem 'benchmark-ips'
gem 'benchmark-memory'
gem 'guard'
gem 'guard-rspec'
gem 'guard-rubocop'
end

group :test do
gem 'rack-contrib', require: false
gem 'rack-test', '< 2.1'
gem 'rspec', '< 4'
gem 'ruby-grape-danger', '~> 0.2.0', require: false
gem 'simplecov', '~> 0.21.2'
gem 'simplecov-lcov', '~> 0.8.0'
gem 'test-prof', require: false
end

platforms :jruby do
gem 'racc'
end

gemspec path: '../'
37 changes: 1 addition & 36 deletions gemfiles/hashie.gemfile
Original file line number Diff line number Diff line change
@@ -1,40 +1,5 @@
# frozen_string_literal: true

# This file was generated by Appraisal

source 'https://rubygems.org'
eval_gemfile '../Gemfile'

gem 'hashie'

group :development, :test do
gem 'bundler'
gem 'rake'
gem 'rubocop', '1.59.0', require: false
gem 'rubocop-performance', '1.20.1', require: false
gem 'rubocop-rspec', '2.25.0', require: false
end

group :development do
gem 'appraisal'
gem 'benchmark-ips'
gem 'benchmark-memory'
gem 'guard'
gem 'guard-rspec'
gem 'guard-rubocop'
end

group :test do
gem 'rack-contrib', require: false
gem 'rack-test', '< 2.1'
gem 'rspec', '< 4'
gem 'ruby-grape-danger', '~> 0.2.0', require: false
gem 'simplecov', '~> 0.21.2'
gem 'simplecov-lcov', '~> 0.8.0'
gem 'test-prof', require: false
end

platforms :jruby do
gem 'racc'
end

gemspec path: '../'
37 changes: 1 addition & 36 deletions gemfiles/multi_json.gemfile
Original file line number Diff line number Diff line change
@@ -1,40 +1,5 @@
# frozen_string_literal: true

# This file was generated by Appraisal

source 'https://rubygems.org'
eval_gemfile '../Gemfile'

gem 'multi_json', require: 'multi_json'

group :development, :test do
gem 'bundler'
gem 'rake'
gem 'rubocop', '1.59.0', require: false
gem 'rubocop-performance', '1.20.1', require: false
gem 'rubocop-rspec', '2.25.0', require: false
end

group :development do
gem 'appraisal'
gem 'benchmark-ips'
gem 'benchmark-memory'
gem 'guard'
gem 'guard-rspec'
gem 'guard-rubocop'
end

group :test do
gem 'rack-contrib', require: false
gem 'rack-test', '< 2.1'
gem 'rspec', '< 4'
gem 'ruby-grape-danger', '~> 0.2.0', require: false
gem 'simplecov', '~> 0.21.2'
gem 'simplecov-lcov', '~> 0.8.0'
gem 'test-prof', require: false
end

platforms :jruby do
gem 'racc'
end

gemspec path: '../'
37 changes: 1 addition & 36 deletions gemfiles/multi_xml.gemfile
Original file line number Diff line number Diff line change
@@ -1,40 +1,5 @@
# frozen_string_literal: true

# This file was generated by Appraisal

source 'https://rubygems.org'
eval_gemfile '../Gemfile'

gem 'multi_xml', require: 'multi_xml'

group :development, :test do
gem 'bundler'
gem 'rake'
gem 'rubocop', '1.59.0', require: false
gem 'rubocop-performance', '1.20.1', require: false
gem 'rubocop-rspec', '2.25.0', require: false
end

group :development do
gem 'appraisal'
gem 'benchmark-ips'
gem 'benchmark-memory'
gem 'guard'
gem 'guard-rspec'
gem 'guard-rubocop'
end

group :test do
gem 'rack-contrib', require: false
gem 'rack-test', '< 2.1'
gem 'rspec', '< 4'
gem 'ruby-grape-danger', '~> 0.2.0', require: false
gem 'simplecov', '~> 0.21.2'
gem 'simplecov-lcov', '~> 0.8.0'
gem 'test-prof', require: false
end

platforms :jruby do
gem 'racc'
end

gemspec path: '../'
Loading
Loading