Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rack-contrib JSONP instead of rack-jsonp #2427

Merged
merged 4 commits into from
Apr 10, 2024

Conversation

ericproulx
Copy link
Contributor

I thought it would be great to use the same JSONP gem in our test suite like we recommend in our README.

@grape-bot
Copy link

grape-bot commented Apr 9, 2024

1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 Danger

@ericproulx ericproulx requested a review from dblock April 9, 2024 19:56
@dblock dblock merged commit 71330b3 into ruby-grape:master Apr 10, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants